Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth: Fix infinite loop when the refresh token is expired #658

Merged
merged 1 commit into from Oct 30, 2018

Conversation

3 participants
@camilasan
Copy link
Member

commented Sep 10, 2018

The server reply with a code 400 when the token is invalid,
the client was understanding this error as a network error, and was retying
again with the same token.

Instead, we must rely on what the json is saying, even if the reply is
not a 200 code.

Issue https://github.com/owncloud/enterprise/issues/2777

OAuth: Fix infinite loop when the refresh token is expired
The server reply with a code 400 when the token is invalid,
the client was understanding this error as a network error, and was retying
again with the same token.

Instead, we must rely on what the json is saying, even if the reply is
not a 200 code.

Issue https://github.com/owncloud/enterprise/issues/2777

@camilasan camilasan requested review from rullzer and juliushaertl Sep 10, 2018

@camilasan camilasan added this to In Review | Testing in Desktop Client 2.5 Series via automation Sep 10, 2018

@rullzer rullzer merged commit ef3aeb6 into master Oct 30, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

Desktop Client 2.5 Series automation moved this from In Review | Testing to Merged | Done | Release! Oct 30, 2018

@rullzer rullzer deleted the upstream/pr/6698 branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.