Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] Display the NC assistant in the main Window #6837

Closed
wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 25, 2024

Backport of #6637

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the 3.13.0 milestone Jun 25, 2024
@camilasan camilasan marked this pull request as ready for review June 25, 2024 14:43
- If NC assistant is enabled in the server, display the icon
to open it instead of Talk. Talk is then displayed in the
list with the other apps.
- The direct link is only available in the assistant app >= 1.0.9.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we backporting UI changes to 3.13?

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6837-236b953c754f62f7a33da036f14c79e21bfa55d8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan
Copy link
Member

Are we backporting UI changes to 3.13?

I will check with Tobias.

@camilasan
Copy link
Member

Are we backporting UI changes to 3.13?

I think that is fine because the UI will only change if you are running the assistant.
Tobias said: "As 3.14 might take a bit longer due to QT6, I am fine with 3.13.1."
I am fine either way.

@camilasan camilasan closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants