Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the syncing status text displayed to the user #6882

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Improve the syncing status text displayed to the user #6882

wants to merge 8 commits into from
+62 −56

Conversation

camilasan
Copy link
Member

before => after:

  • "Reconciling changes" => "Reconciling local and remote changes"
  • "Syncing changes" => "Syncing"
  • "Downloading %1. Please wait …" => "Downloading %1 …" (this is the updater status though)
  • "0 of 6 files" => "1 of 6 files" (do not display 0, but 1)"
  • "Synchronizing VirtualFiles with local folder" => "Synchronizing virtual files in local folder"
  • "Synchronizing with local folder" => "Synchronizing files in local folder"
  • "Waiting …" => "About to start syncing"
    Screenshot 2024-07-05 at 14 10 54
  • "Preparing sync" => "Checking folder changes"
    Screenshot 2024-07-05 at 15 03 23

@camilasan
Show details of the syncing progress in the settings dialog.
3401eff 
Before it was only shown in the tooltip.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Modernize FolderStatusModel::slotSetProgress.
aa10af9 
- Add const auto.
- Change variable names to be more clear.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Never display "please wait" to users.
aca1223 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Add margin to sync progress text.
9cfdf46 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Change text 'waiting' to a more clear description of the sync status.
e3c6d7f 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Always display the sync status in one line.
9565f71 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Only start displaying status starting at 1.
0498f2a 
e.g. "0 f 6 files" => "1 of 6 files"

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve syncing information given to user by changing the text.
ed2ec16 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6882-ed2ec16edf607c88dd32a1a112e77548406e0cab-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
36 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

claucambra
claucambra approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the readability improvements, I am a huge fan 🙂

I left a small comment but otherwise it looks ok to me

It's a draft so if things change substantially I can re-review

src/gui/folderstatusmodel.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilasan @nextcloud-desktop-bot @claucambra