Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsDialog: fix a little glitch in the account tool button size #812

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@jpnurmi
Copy link
Member

commented Nov 12, 2018

SettingsDialog::accountAdded() uses the height of the toolbar to
calculate the desired default size for toolbuttons. Make sure to have
the "General" and "Network" tool buttons in place before calling
accountAdded() to avoid cramped first button.

SettingsDialog: fix a little glitch in the account tool button size
SettingsDialog::accountAdded() uses the height of the toolbar to
calculate the desired default size for toolbuttons. Make sure to have
the "General" and "Network" tool buttons in place before calling
accountAdded() to avoid cramped first button.
@jpnurmi

This comment has been minimized.

Copy link
Member Author

commented Nov 12, 2018

The first account button looks often like this:
screenshot from 2018-11-12 18-48-46

To reproduce the issue, make sure the first account is offline/unreachable so that SettingsDialog::slotAccountAvatarChanged() or SettingsDialog::slotAccountDisplayNameChanged() does not get called. These will eventually fixup the button size, which is why the issue went unnoticed for a while.

After the fix:
screenshot from 2018-11-12 18-53-14

@jpnurmi jpnurmi requested review from camilasan and rullzer Nov 12, 2018

@rullzer rullzer merged commit 9de32d2 into nextcloud:master Nov 12, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@jpnurmi jpnurmi deleted the jpnurmi:settings-dialog-accounts branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.