Make sure _profile and _page are deleted in the correct order #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by electron/electron#15028 Closes #941 Closes #950
|
Cannot judge the code, at least I can say the version from community-testing (cf. #941 (comment)) works for me :) |
blizzz
requested review from
camilasan and
rullzer
and removed request for
camilasan
|
Thanks for your contribution @yan12125 |
juliushaertl
approved these changes
Dec 22, 2018
svenstaro
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jul 22, 2020
* All patches are merged upstream, yay! [1][2] [1] nextcloud/desktop#946 [2] nextcloud/desktop#959 * qtwebengine is not really necessary. Here are IRC logs on freenode.net#nextcloud-client, starting from 2019/1/1 21:23:38 UTC+8: [21:23:38] <yan12125> Hi, maintainer of Arch Linux package nextcloud-client here. [21:23:41] <yan12125> https://github.com/nextcloud/desktop/wiki/How-to-compile-the-desktop-client [21:24:18] <yan12125> On this page -DNO_SHIBBOLETH=1 is used to configure the desktop client. Is it the suggested configuration? [01:42:25] <camilasan> Yes, unless you do use shibboleth... [01:42:40] <camilasan> yan12125 ^ [10:38:24] <yan12125> Thanks camilasan! Sounds like it's still a working feature, just that few people use that? [15:53:49] <rullzer> yan12125: well not really as qwebkit is not really supported anymore. But shibboleth should now also work just fine with the new login flow :) [19:25:46] <yan12125> rullzer: thank you very much for the information! I'll disable the feature in the next Arch package update. [19:26:56] <yan12125> On Arch nextcloud-client depends on both qtwebkit and qtwebengine, which confuses some users, and it's a great news that it works with only qtwebengine. [19:32:21] <rullzer> yan12125: yeah should work. And then only qtwebengine is needed ;) git-svn-id: file:///srv/repos/svn-community/svn@442911 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by electron/electron#15028
Closes #941
Closes #950