Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust base images to supported versions #643

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: Adjust base images to supported versions #643

merged 1 commit into from
Jul 3, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 25, 2024

  • The first version of Nextcloud supporting PHP 8.2 was 26 which requires Bullseye as Debian version.
  • The first version of Nextcloud supporting PHP 8.3 was 28 which requires Bookwork as Debian version.

@susnux
fix: Adjust base images to supported versions
7bee19a 
The first version of Nextcloud supporting PHP 8.2 was 26 which requires Bullseye as Debian version.
The first version of Nextcloud supporting PHP 8.3 was 28 which requires Bookwork as Debian version.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nickvergessen
Copy link
Member

Are we fixing a problem or are we just planning to break CI on stable branches? 🙈

@susnux
Copy link
Contributor Author

susnux commented Jun 26, 2024

Test with real supported systems instead of outdated versions, so nothing should break and if we have a different problem 👀

@danxuliu
Copy link
Member

danxuliu commented Jul 2, 2024

Note that, since a few hours ago, sury repository no longer provides packages for Debian Buster (see 2098 in https://github.com/oerdnj/deb.sury.org/issues/, not directly linking to avoid polluting the issue with backlinks). Therefore it is no longer possible to use the Docker images and install additional packages provided by the repository, like libapache2-mod-php8.2 (which, since a few months ago, also required updating the repository key as described in 2074#issuecomment-1950238946, as the key included in the Docker image was expired).

st3iny
st3iny approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Image builds fine locally.

@nickvergessen nickvergessen merged commit 530de60 into master Jul 3, 2024
4 checks passed
@nickvergessen nickvergessen deleted the fix/baseimage-version branch July 3, 2024 09:40
@nickvergessen
Copy link
Member

Triggered the builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@susnux @nickvergessen @danxuliu @st3iny