Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(developer): Mention symfony/event-dispatcher #11245

Merged
merged 1 commit into from Oct 27, 2023
Merged

fix(developer): Mention symfony/event-dispatcher #11245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ Make sure your ``appinfo/info.xml`` allows for Nextcloud 28.
.. code-block:: xml

<dependencies>
<nextcloud min-version="25" max-version="28" />
<nextcloud min-version="26" max-version="28" />
</dependencies>

Front-end changes
Expand Down Expand Up @@ -112,6 +112,20 @@ Some (minor) breaking changes were inevitable. Here's the summary:

The details of this change can also be seen in the `pull request on GitHub <https://github.com/nextcloud/server/pull/38556>`__ and in the upstream documentation `dbal 3.7.x upgrade document <https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md>`__.

``symfony/event-dispatcher``
****************************

Over the last 2 major versions the ``symfony/event-dispatcher`` package first deprecated and then removed the way Nextcloud
server dispatched old events. This means the way we wrapped away symfony's ``\Symfony\Component\EventDispatcher\EventDispatcherInterface``
as well as using the ``\Symfony\Component\EventDispatcher\GenericEvent`` could not be kept alive in a backwards compatible way.

Therefore migrating from ``\Symfony\Component\EventDispatcher\EventDispatcherInterface``
to ``\OCP\EventDispatcher\IEventDispatcher`` (exists since Nextcloud 17) is required to be compatible with Nextcloud 28.
All code places that dispatched a ``\Symfony\Component\EventDispatcher\GenericEvent`` have been adjusted
and have ``\OCP\EventDispatcher\Event`` based dedicated event now that is dispatched as a typed-event so all available parameters are documented.

The details of this change can also be seen in the todo items that are linked from the `pull request on GitHub <https://github.com/nextcloud/server/pull/38546>`__.

Added APIs
^^^^^^^^^^

Expand Down