Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): Update supported database support #11473

Merged
merged 1 commit into from Feb 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 27, 2024

☑️ Resolves

  • Resolves https://github.com/nextcloud-gmbh/server/issues/721
    • We need support for mariadb 10.11 as this is the only version provided by our supported Debian 12 version
    • mariadb 10.4 is not used by any supported or used distribution and EOL with Nextcloud 29
    • mariadb 10.3 is EOL but we need to keep support as long as we support Ubuntu 20.04
    • Postgres 10 and 11 are EOL and not used by any distribution we support or is used, all distributions also provide at least Postgres 12

BTW mariadb 10.11 is the current LTS version.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger
Copy link
Member

Fine by me, also looping in @sorbaugh @nickvergessen @ChristophWurst @juliushaertl FYI.

At some point we might want/need to restructure is since some versions/support are linked between different requirements, like OS and DB versions. Like mentioned by @susnux 10.4 is too high for Ubuntu 20 but 22 would your versions larger than 10.5 yet it is likely confusing people if we support 10.3 and 10.5 but not 10.4 - so maybe leave it in to not confuse people because an explanation might just be as confusing?

@susnux
Copy link
Contributor Author

susnux commented Jan 28, 2024

Well but we then also support 10.6 an 10.11 but not 10.7/8/9/10 due to the fact they are EOL, right?

Or we might add a note like "only supported on Ubuntu 20.04" or similar? Not sure if we want to guarantee working solution for EOL like 10.4. So I am fine with every decision here (just would like to have 10.11 officially supported 😉 )

@susnux susnux requested review from nickvergessen, juliushaertl, sorbaugh and ChristophWurst and removed request for szaimen January 28, 2024 16:43
@AndyScherzinger
Copy link
Member

Well 10.11 we should add of course (if it has been tested, best if run in CI in our matrix). For the older versions, I am fine with removing or keeping the versions. My main issue is to align on a way that makes this clear to the readers :)

@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2024

merge then or not merge?

@nickvergessen
Copy link
Member

/backport to stable28

@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2024

/backport to stable28

But we dont test postgres16 and co. on stable28 currently?

@nickvergessen
Copy link
Member

yeah, right. But the removals and 10.11 still should go there

@come-nc come-nc merged commit bdf25c6 into master Feb 8, 2024
11 checks passed
@come-nc come-nc deleted the update-database-support branch February 8, 2024 10:22
@szaimen szaimen added this to the Nextcloud 29 milestone Apr 24, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants