Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(admin): Warn to choose custom app values carefully #11578

Merged
merged 1 commit into from Feb 23, 2024
Merged

docs(admin): Warn to choose custom app values carefully #11578

merged 1 commit into from Feb 23, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Feb 23, 2024 •
edited

  • Adds warning to custom app directories section to make sure that the config any custom apps do not conflict with existing directories.
  • Updates the example to use extra-apps rather than apps2 for clarity
  • Technically there are other values we'd probably like to discourage, that may not appear as listed folders in installation directory (i.e. any built-in URL used by Nextcloud itself), but until/unless we build in extensive checks, we can at least document with a big warning.

☑️ Resolves

🖼️ Screenshots

image

@joshtrichards
docs(admin): Warn to choose custom app values carefully
ed7c420 
* Add warnign to custom app directories section to make sure that the values (locations) any custom apps directories chosen do not conflict with existing directories
* Update the example to use `extra-apps` rather than `apps2` for clarity

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards joshtrichards merged commit f4924a7 into master Feb 23, 2024
11 checks passed
@joshtrichards joshtrichards deleted the docs/admin/apps-custom-dirs branch February 23, 2024 20:04
@backportbot backportbot bot mentioned this pull request Feb 23, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
enhancement feature: apps management feedback-requested manual: admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshtrichards @kesselb