-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Built-in CODE Server (ARM64) #11596
Conversation
Signed-off-by: Dominic Giebert <dominic.giebert@suse.com>
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
Holy crap! How did we overlook this? Thanks for fixing this! Best as I can tell, way back in #2197 the arm64 handling was noted, but the legacy routes were removed outright so it was a non-issue, but then when #7141 added back the legacy route handling it got overlooked. I've looked at that config probably hundreds of times. 😞 Needs to be added here too in (via the same PR or one immediately following):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshtrichards thanks for catching this, it needs to be fixed in both config files.
Signed-off-by: Dominic Giebert <dominic.giebert@suse.com>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Needed to support the arm64 Code Server, also used here nextcloud/helm#540