Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail_domain clarification re: SMTP EHLO #11606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

monochromec
Copy link

☑️ Resolves

Signed-off-by: monochromec <monochromec@gmail.com>
Signed-off-by: monochromec <monochromec@gmail.com>
Signed-off-by: monochromec <monochromec@gmail.com>
@monochromec
Copy link
Author

Fixed malformed link.

of course.
of course. Please note that this is *not* the domain used for the SMTP protocol handhshake.
So if you want to have the server responding with an EHLO reply identifiying itself properly,
please configure ``overwrite.cli.url`` accordingly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather say that it uses the value of overwrite.cli.url. Because like that, you might get the impression to set this variable accordingly to make the mail delivery work. But it has other consequences as well (it's not use exclusively for the mail EHLO).

@joshtrichards
Copy link
Member

This is already noted in the actual E-mail configuration chapter:

https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/email_configuration.html#configuring-an-smtp-server

Note

The overwrite.cli.url parameter from config.php will be used for the SMTP EHLO.

I don't think it needs to be included in the config.sample.php personally (as proposed in this PR) since it's a fairly obscure customization, but if one is going to do that... the config.sample.php in this repository is actually pulled from the server repository here. The PR would have to be against that.

@joshtrichards joshtrichards changed the title mail_domain clarification mail_domain clarification re: SMTP EHLO Mar 12, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants