Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(admin): Fix caldav instructions for occ config:app:set #11635

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 11, 2024

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

@JB1985 @gramels please review

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

Comment on lines 151 to 152
php occ config:app:set calendar rateLimitCalendarCreation --value=15
php occ config:app:set calendar rateLimitPeriodCalendarCreation --value=1800
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php occ config:app:set calendar rateLimitCalendarCreation --value=15
php occ config:app:set calendar rateLimitPeriodCalendarCreation --value=1800
php occ config:app:set dav rateLimitCalendarCreation --value=15
php occ config:app:set dav rateLimitPeriodCalendarCreation --value=1800

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I'll cherry-pick #11636 onto this branch


or::

# Allow users to create calendars/subscriptions without restriction
php occ config:app:set calendar maximumCalendarsSubscriptions --type=integer --value=-1
php occ config:app:set calendar maximumCalendarsSubscriptions --value=-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php occ config:app:set calendar maximumCalendarsSubscriptions --value=-1
php occ config:app:set dav maximumCalendarsSubscriptions --value=-1


Additionally, the maximum number of calendars and subscriptions a user may create is limited to 30 items. This can be customized too::

# Allow users to create 50 calendars/subscriptions
php occ config:app:set calendar maximumCalendarsSubscriptions --type=integer --value=50
php occ config:app:set calendar maximumCalendarsSubscriptions --value=50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php occ config:app:set calendar maximumCalendarsSubscriptions --value=50
php occ config:app:set dav maximumCalendarsSubscriptions --value=50

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst merged commit 3c66321 into stable28 Mar 13, 2024
11 checks passed
@ChristophWurst ChristophWurst deleted the fix/admin/caldav-rate-limit-occ branch March 13, 2024 11:53
Copy link

backportbot bot commented Mar 13, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/11635/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00ce165f 180d41cd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/11635/stable26

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants