fix(trashbin): Add missing size/expire commands to occ commmand list #11805
Conversation
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
| trashbin:cleanup [--all-users] [--] [<user_id>...] Permanently remove deleted files | ||
| trashbin:restore [--all-users] [--scope[=SCOPE]] [--since[=SINCE]] [--until[=UNTIL]] [--dry-run] [--] [<user_id>...] Restore deleted files according to the given filters | ||
| trashbin:cleanup Permanently remove deleted files | ||
| trashbin:expire Expires the users trashbin |
There was a problem hiding this comment.
The expire command is not really clear for me, you give a date or something after that it deletes the files?
There was a problem hiding this comment.
At present I'm just adding the missing command to the basic list that exists for each command per our current convention.
The description text there is pulled from the command output itself. Further details (the options) are available by running the command. Someone can do a follow-up PR in the spot down below that with examples if they want.
There was a problem hiding this comment.
Ok, I created a bug report for clarification: nextcloud/server#45418
|
|
||
| trashbin | ||
| trashbin:cleanup [--all-users] [--] [<user_id>...] Permanently remove deleted files | ||
| trashbin:restore [--all-users] [--scope[=SCOPE]] [--since[=SINCE]] [--until[=UNTIL]] [--dry-run] [--] [<user_id>...] Restore deleted files according to the given filters |
There was a problem hiding this comment.
Having the options is really nice, especially with filters because the GUI is limited in this respect.
There was a problem hiding this comment.
Currently in the occ command docs, in the list of commands for each area the options are never listed. This one was an oddball and it made the table challenging to read. I agree options can make sense in the docs, but not in that spot currently. Many of the command sections have examples and additional bits after the command listing. Perhaps something there in a follow-up PR.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
☑️ Resolves
Adds to the list of commands:
Doesn't actually show their usage, but at least they're listed now. I didn't even realize
occ trashbin:sizewas a command. Kind of handy for setting a size when you aren't using quotas.🖼️ Screenshots