-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds automation to build catalog templates. #2223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreozoux
changed the title
Adds automation to build catalog templates.
[WIP] Adds automation to build catalog templates.
Jul 24, 2020
pierreozoux
force-pushed
the
transifex-2
branch
3 times, most recently
from
July 24, 2020 12:15
c3a0c29
to
b2fa962
Compare
pierreozoux
changed the title
[WIP] Adds automation to build catalog templates.
Adds automation to build catalog templates.
Jul 24, 2020
skjnldsv
reviewed
Jul 24, 2020
skjnldsv
reviewed
Jul 24, 2020
skjnldsv
reviewed
Jul 24, 2020
skjnldsv
reviewed
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see comments :)
We'll have to merge to test it 🙈
skjnldsv
reviewed
Jul 24, 2020
Same as #2223 (comment) |
Yes, no problem for the last comment. |
pierreozoux
force-pushed
the
transifex-2
branch
2 times, most recently
from
July 24, 2020 15:01
bfdba5c
to
70cae04
Compare
Ok, I think we are good :) |
Signed-off-by: pierreozoux <pierre@ozoux.net>
skjnldsv
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the necessary first step to then automate transifex fetch/push with this yml:
Once the PR is merged, the github action should populate the folder
user_manual/locale/source
with a new commit.Then we can configure transifex to fetch and push.
Translated strings should appear in
user_manual/locale/<lang>/LC_MESSAGES
This PR superseeds #1824 I'll still need to make another PR to automatically build all the translated docs, but I need the files locally, hence this first PR :)