Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds automation to build catalog templates. #2223

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Adds automation to build catalog templates. #2223

merged 1 commit into from
Jul 24, 2020

Conversation

pierreozoux
Copy link
Member

@pierreozoux pierreozoux commented Jul 24, 2020

This is the necessary first step to then automate transifex fetch/push with this yml:

filters:
- filter_type: dir
  file_format: PO
  source_language: en
  source_file_dir: user_manual/locale/source
  # path expression to translation files, must contain <lang> placeholder
  translation_files_expression: 'user_manual/locale/<lang>/LC_MESSAGES'

Once the PR is merged, the github action should populate the folder user_manual/locale/source with a new commit.
Then we can configure transifex to fetch and push.

Translated strings should appear in user_manual/locale/<lang>/LC_MESSAGES

This PR superseeds #1824 I'll still need to make another PR to automatically build all the translated docs, but I need the files locally, hence this first PR :)

@pierreozoux pierreozoux changed the title Adds automation to build catalog templates. [WIP] Adds automation to build catalog templates. Jul 24, 2020
@pierreozoux pierreozoux force-pushed the transifex-2 branch 3 times, most recently from c3a0c29 to b2fa962 Compare July 24, 2020 12:15
@pierreozoux pierreozoux changed the title [WIP] Adds automation to build catalog templates. Adds automation to build catalog templates. Jul 24, 2020
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see comments :)
We'll have to merge to test it 🙈

user_manual/Makefile Outdated Show resolved Hide resolved
@skjnldsv
Copy link
Member

Translated strings should appear in user_manual/locale/<lang>/LC_MESSAGES

Same as #2223 (comment)
Can we use l10n instead? For consistency

@pierreozoux
Copy link
Member Author

Yes, no problem for the last comment.

@pierreozoux pierreozoux force-pushed the transifex-2 branch 2 times, most recently from bfdba5c to 70cae04 Compare July 24, 2020 15:01
@pierreozoux
Copy link
Member Author

Ok, I think we are good :)

Signed-off-by: pierreozoux <pierre@ozoux.net>
@skjnldsv skjnldsv merged commit 36a0368 into master Jul 24, 2020
@skjnldsv skjnldsv deleted the transifex-2 branch July 24, 2020 15:26
@pierreozoux pierreozoux restored the transifex-2 branch July 27, 2020 11:34
@pierreozoux pierreozoux deleted the transifex-2 branch July 27, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants