Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pretty URLs #556

Merged
merged 1 commit into from Aug 31, 2017
Merged

Update pretty URLs #556

merged 1 commit into from Aug 31, 2017

Conversation

tflidd
Copy link
Contributor

@tflidd tflidd commented Aug 24, 2017

Fixes #522

@tflidd
Copy link
Contributor Author

tflidd commented Aug 24, 2017

Is this the same issue? #54
@oparoz

@tflidd
Copy link
Contributor Author

tflidd commented Aug 24, 2017

Really strange, it does rewrite well for some svg-files, same error like in this issue:
https://help.nextcloud.com/t/icons-missing-path-not-rewritten/4722/18

jasonbayton
jasonbayton approved these changes Aug 26, 2017
View reviewed changes
Copy link
Member

@jasonbayton jasonbayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tflidd tflidd mentioned this pull request Aug 26, 2017
Closed
MorrisJobke
MorrisJobke approved these changes Aug 31, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@MorrisJobke MorrisJobke merged commit 6455185 into master Aug 31, 2017
@MorrisJobke MorrisJobke deleted the fix522 branch August 31, 2017 10:32
@MorrisJobke MorrisJobke mentioned this pull request Aug 31, 2017
Closed
@MorrisJobke
Copy link
Member

stable12 0d72ad8

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jasonbayton jasonbayton jasonbayton approved these changes

@MariusBluem MariusBluem Awaiting requested review from MariusBluem

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tflidd @MorrisJobke @jasonbayton