Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double prompt to setup e2ee passphrase. #248

Closed
ph00lt0 opened this issue Aug 13, 2021 · 8 comments
Closed

Double prompt to setup e2ee passphrase. #248

ph00lt0 opened this issue Aug 13, 2021 · 8 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working client: 💻 desktop client: 🤖🍏 mobile feature: activation Setting the mnemonic mostly needs info Not enough information provided

Comments

@ph00lt0
Copy link

ph00lt0 commented Aug 13, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.

Steps to reproduce

  1. Install the end to end encryption app
  2. Setup a passphrase on MacOS
  3. Create a new folder
  4. Enable encryption for this folder
  5. Open android app
  6. Click on newly created folder
  7. You will be prompted to setup passphrase again.

Expected behaviour

I should only be prompted once to setup a passphrase.

Actual behaviour

Now I can sync e2ee encrypted files from 2 devices with a different encryption within the same account, very useless. My macbook syncs data with another key as the android client and there is no way to reset this, or change this.

Server configuration

Operating system:
Nextcloud snap on Ubuntu 21

Nextcloud version: (see Nextcloud admin page)
21.0.3

Logs

I obviously can't share full logs and debugging. But there is an fatal error: Failed to handle NewFileInfoEvent . and the following error happens when I create a document in the folder: OCP\Files\NotFoundException

@ph00lt0 ph00lt0 added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Aug 13, 2021
@ph00lt0
Copy link
Author

ph00lt0 commented Aug 13, 2021

When uploading files from android, in the client I get a connection error. In the logs it shows the following:
OCA\EndToEndEncryption\Exceptions\MissingMetaDataException: Intermediate meta-data file missing

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 13, 2021

My guess is that the "solution" for crashed setups of this app actually do not work sufficiently. #32

We really need a way to reset the app data fully.

@asheroto
Copy link

asheroto commented Nov 12, 2021

This happening for me as well. Using Windows client. If I click "Enable encryption" on the message, then click ok, close out, and reopen settings, the message reappears.

Uninstalled and reinstalled the client. Now it just says "display mnemonic"... does that mean E2EE is working now?

@bcutter
Copy link

bcutter commented Jan 29, 2022

Uninstalled and reinstalled the client. Now it just says "display mnemonic"... does that mean E2EE is working now?

If you actually see your mnemonic once clicking that button, that's a good indicator E2EE has been setup for that endpoint/client.

@joshtrichards
Copy link
Member

Open android app
Click on newly created folder
You will be prompted to setup passphrase again

This could have been an Android client issue. It sounds like it was. Probably not an issue here with this app.

Now I can sync e2ee encrypted files from 2 devices with a different encryption within the same account, very useless. My macbook syncs data with another key as the android client and there is no way to reset this, or change this.
[...]
We really need a way to reset the app data fully.

That was added in #305.

No idea for sure how you ended up with the conflict between the clients and virtually impossible to try to reproduce without the exact same client versions you had in place at the time. A lot of E2EE code has changed in each of the clients since this report. In addition the clients are more proactively informed now if keys already exist for a user (e.g. #360) even before attempting to add new keys.

If you can reproduce this behavior still today, please provide the server-app and client versions involved.

@joshtrichards joshtrichards added needs info Not enough information provided client: 💻 desktop labels Jan 5, 2024
@ph00lt0
Copy link
Author

ph00lt0 commented Jan 5, 2024

Lol no i stopped using nextcloud because of the insane amount of bugs like this. 3 years later someone replies, this must be a joke.

@joshtrichards
Copy link
Member

Fair enough.

3 years later someone replies, this must be a joke.

Nextcloud is a large open source project spread across hundreds of repositories. Limited resources and many of us are volunteers.

Timely, individualized responses to every bug report aren't particularly realistic via this channel.

Even so, matters are often addressed, without developers getting the opportunity to follow-up on every potentially relevant or overlapping issue in the backlog personally and in real time (there are other channels with SLAs available for that).

I happen to be triaging the old backlog and attempting to identify some of the matters that have already been addressed in the code base or in the clients (i.e. the bug was never here in this app since the bulk of the implementation is in the clients). Or those that need improved documentation or to be moved to more appropriate places (like one of the clients involved) in order to o get the correct eyes on them.

I'm going to close this Issue, since there's nothing remaining that is actionable. Thanks for reporting the issue originally. I'm sorry things didn't work out.

@asheroto
Copy link

asheroto commented Jan 5, 2024

@joshtrichards thanks for the insight into the org. I know that Issues aren't really a place to discuss this, but was curious does Nextcloud Enterprise have a separate development team or do they work with the volunteers? Truly just interested in learning how the organization works. 😊

I know you may not hear it as often as you like, but I really appreciate your time and commitment to Nextcloud. I believe Nextcloud is excellent, just has some kinks that will eventually get worked out. I contribute a lot of code to repos as well and understand the time involved, so thanks again! 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working client: 💻 desktop client: 🤖🍏 mobile feature: activation Setting the mnemonic mostly needs info Not enough information provided
Projects
None yet
Development

No branches or pull requests

4 participants