Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardDAV and CalDAV stop working with E2EE enabled. #3

Closed
mannp opened this issue Oct 1, 2017 · 17 comments · Fixed by #4
Closed

CardDAV and CalDAV stop working with E2EE enabled. #3

mannp opened this issue Oct 1, 2017 · 17 comments · Fixed by #4
Labels
bug Something isn't working

Comments

@mannp
Copy link

mannp commented Oct 1, 2017

Both are working fine before enabling the plugin and both work fine again once E2EE is disabled again.

There is no mention of this being a restriction, so have assumed it is a bug.

@schiessle
Copy link
Member

Thanks, this is probably caused by the sabredav plugins implemented here. I will look into it.

@schiessle
Copy link
Member

@mannp this should solve the issue: #4 Maybe you can give it a try and report back? Thanks a lot!

@mannp
Copy link
Author

mannp commented Oct 4, 2017

@schiessle thanks for the update.

I am using a git version of the plugin and have done a new git pull for your changes, but sill lose access with E2EE enabled.

Am I picking up all the changes? Are they solely in an updated plugin?

I have done the git pull and rebooted my server just in case and still have no access via CardDav or Caldav; getting 404.

I also lose connection on my android phone through davdroid.

@schiessle
Copy link
Member

@mannp you need to checkout the branch with the fix: git checkout only-files

@mannp
Copy link
Author

mannp commented Oct 4, 2017

@schiessle Oops! So, with initial tests on that branch I am able to sync both Dav's on the mac and android devices.

I will take a further look tomorrow, as I haven't configured e2ee yet, but initial tests look good 👍

@schiessle
Copy link
Member

Great, thanks for testing @mannp !

@mannp
Copy link
Author

mannp commented Oct 5, 2017

@schiessle Hi there. So I have had no issues with CalDAV and CardDav syncing now, but I now cannot upload files from the latest android app to my server, they just error out.

I also cannot setup E2EE which might be related to not being able to upload files.

Happy to create a new issue if these are unrelated to CardDav and CalDAV.

The errors in my log are as follows;

end_to_end_encryption | Can't create public key: could not sign the CSR, please make sure to submit a valid CSR
-- | --

PHP | openssl_csr_sign(): cannot get CSR from parameter 1 at /config/www/nextcloud/apps/end_to_end_encryption/lib/SignatureHandler.php#60
-- | --

webdav | OCA\DAV\Connector\Sabre\Exception\InvalidPath: Dot files are not allowed
-- | --

@schiessle
Copy link
Member

At first sight I would say that this is not related, creating a public key should be completely independent from the DAV request. Looks like the Android client sends a wrong CSR... @tobiasKaminsky what do you think?

@schiessle
Copy link
Member

@mannp just to double check, if you switch back to the master branch it works again?

@tobiasKaminsky
Copy link
Member

@schiessle the first error message is related to E2E, but the third one "InvalidPath: Dot files are not allowed"....?

@schiessle
Copy link
Member

@tobiasKaminsky maybe you can try the pull request as well? #4? Then we can debug it together...Thanks!

@mannp
Copy link
Author

mannp commented Oct 9, 2017

@schiessle Thats a good question as I hadn't bothered to setup E2EE before as I didn't want to sacrifice the DAV's to test it.

I will revert back to master and try to setup directly, but it would be good if @tobiasKaminsky has chance to test too, as the interoperability is pretty critical 👍 and perhaps not best left to my level of testing :)

@tobiasKaminsky
Copy link
Member

@schiessle I have the same problem, but also with your PR :/

@ConorIA
Copy link

ConorIA commented Oct 9, 2017

I can confirm that my Android app hangs at "Generating new keys..." when the #4 branch is active on the server.

@mannp
Copy link
Author

mannp commented Oct 12, 2017

@schiessle It's not particularly clear to me but it seems the csr error is present in both branches.

@mannp
Copy link
Author

mannp commented Oct 23, 2017

Did this one get resolved? or is in progress, or not being looked at :) ?

No updates to the code, so I am assuming its on hold?

Thanks in advance

@schiessle
Copy link
Member

@mannp we could just test it successfully with some small changes. I merged it now into master. Please reopen the issue (or create a new one) if you still experience any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants