Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply sabredav plugin only to files and directory, not to contacts or calendars #4

Merged
merged 2 commits into from
Oct 25, 2017

Conversation

schiessle
Copy link
Member

apply sabredav plugin only to files and directory, not to contacts or calendars

fix #3

@schiessle schiessle added the 3. to review Waiting for reviews label Oct 4, 2017
@schiessle schiessle added this to the Nextcloud 13 milestone Oct 4, 2017
@schiessle
Copy link
Member Author

@tobiasKaminsky maybe you can test this with Android if both works:

  • upload/download encrypted files
  • sync a contact and calender entry

Thanks!

… calendars

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@tobiasKaminsky
Copy link
Member

With this branch enabled I get, when trying to create a folder within the app:

{"reqId":"X7krD7X0a3Ltq0oM8SIk","level":4,"time":"2017-10-25T05:42:38+00:00","remoteAddr":"2.247.246.131","user":"dav","app":"webdav","method":"MKCOL","url":"\/remote.php\/webdav\/Fty\/","message":"Exception: {\"Exception\":\"OCA\\\\DAV\\\\Connector\\\\Sabre\\\\Exception\\\\InvalidPath\",\"Message\":\"Dot files are not allowed\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www-home\\\/end_to_end_encryption\\\/lib\\\/Connector\\\/Sabre\\\/LockPlugin.php(166): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\ObjectTree->getNodeForPath('.')\\n#1 \\\/var\\\/www-home\\\/end_to_end_encryption\\\/lib\\\/Connector\\\/Sabre\\\/LockPlugin.php(109): OCA\\\\EndToEndEncryption\\\\Connector\\\\Sabre\\\\LockPlugin->getNodeForPath('Fty')\\n#2 [internal function]: OCA\\\\EndToEndEncryption\\\\Connector\\\\Sabre\\\\LockPlugin->checkLock(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#3 \\\/var\\\/www\\\/nc-crypt\\\/3rdparty\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#4 \\\/var\\\/www\\\/nc-crypt\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(466): Sabre\\\\Event\\\\EventEmitter->emit('beforeMethod', Array)\\n#5 \\\/var\\\/www\\\/nc-crypt\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#6 \\\/var\\\/www\\\/nc-crypt\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(76): Sabre\\\\DAV\\\\Server->exec()\\n#7 \\\/var\\\/www\\\/nc-crypt\\\/remote.php(162): require_once('\\\/var\\\/www\\\/nc-cry...')\\n#8 {main}\",\"File\":\"\\\/var\\\/www\\\/nc-crypt\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/ObjectTree.php\",\"Line\":129}","userAgent":"Mozilla\/5.0 (Android) ownCloud-android\/2.0.0-e2e-02","version":"13.0.0.3"}

With master branch of this app it is working again.

…e it to '/'

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle
Copy link
Member Author

@tobiasKaminsky please retry, should be fixed now.

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about the code, but it is working as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CardDAV and CalDAV stop working with E2EE enabled.
2 participants