Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about SSE #231

Merged
merged 1 commit into from Apr 20, 2021
Merged

Add note about SSE #231

merged 1 commit into from Apr 20, 2021

Conversation

juliushaertl
Copy link
Member

No description provided.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #231 (bb259e2) into master (5ad5843) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #231   +/-   ##
=========================================
  Coverage     83.78%   83.78%           
  Complexity      328      328           
=========================================
  Files            30       30           
  Lines           925      925           
=========================================
  Hits            775      775           
  Misses          150      150           
Flag Coverage Δ Complexity Δ
php 83.78% <ø> (ø) 328.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad5843...bb259e2. Read the comment docs.

@rullzer rullzer merged commit 27f51b8 into master Apr 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the docs/sse-e2ee branch April 20, 2021 07:16
@robolange
Copy link

@rullzer Can you explain what this means? What is incompatible? What is the consequence of running both modules simultaneously? I currently have a test system running NC 21.0.1 with server side encryption (default module) and End-to-End Encryption and everything seems to work correctly. I can see that on the server, the E2EE encrypted files are also encrypted with the server-side module, but they are still named using hashes instead of file names, as when using E2EE alone. If I do not enter the correct E2EE mnemonic on a new client, I cannot see those files. If I do enter the correct mnemonic and resync, then I am able to view the E2EE encrypted files.

My biggest fear when both modules are enabled is that the files are somehow encrypted using only the server side key. But, I can't figure out how this could be the case, because the files should already be encrypted before being sent to the server. I would like to answer this question definitively by manually decrypting a few of these files using the server-side key, to verify that they are indeed still encrypted with the E2EE key as well. Any pointers you have on doing this would be appreciated.

So I guess what I'm asking, is why are these modules considered incompatible? Server-side encryption may be somewhat redundant when E2EE is enabled, but at least with my current testing, they appear to work together properly.

@juliushaertl
Copy link
Member Author

The main issue here is that both encryption modules make use of the encrypted column of the filecache so there might be unexpected behaviour due to that and currently this is neither tested nor supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants