Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: groups placeholder #581

Merged
merged 1 commit into from Nov 10, 2023
Merged

feat: groups placeholder #581

merged 1 commit into from Nov 10, 2023

Conversation

pReya
Copy link
Contributor

@pReya pReya commented Nov 7, 2023

  • new version of my last pr feat: add groups dynamic placeholder #579 (sorry, messed up the rebasing)
  • allow {groups} as a dynamic placeholder for external sites (this is a very common scenario to do something/change content on the external site based on group membership)
  • groups array elements will be joined with a comma and then url-encoded

Signed-off-by: Moritz Stückler <moritz@bitbetter.de>
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pReya!

If anyone else needs this and wants to make the separator configurable please open a PR.

@provokateurin provokateurin merged commit 1944edb into nextcloud:master Nov 10, 2023
18 checks passed
@pReya pReya deleted the feat/groups-placeholder branch November 10, 2023 13:55
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants