Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show proper error message when trying to unlock as someone else #133

Merged
merged 1 commit into from Apr 12, 2023
Merged

fix: Show proper error message when trying to unlock as someone else #133

merged 1 commit into from Apr 12, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Apr 12, 2023 •
edited

Regression from #53 as OCS is XML by default so we need to pass format=json to get the proper result

Steps to reproduce:

  • user1 shares a file with user2
  • user1 locks the file
  • user2 tries to unlock

@juliushaertl
fix: Show proper error message when trying to unlock as someone else
522fa06 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added the bug Something isn't working label Apr 12, 2023
datenangebot
datenangebot approved these changes Apr 12, 2023
View reviewed changes
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ straight forward

@juliushaertl juliushaertl merged commit 7371979 into main Apr 12, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/unlock-error branch April 12, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliushaertl @datenangebot