Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock state icon position in detailed files' lists #176

Merged
merged 2 commits into from Feb 13, 2024

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Oct 11, 2023

Before :
Capture d’écran du 2023-10-11 15-38-40
After :
Capture d’écran du 2023-10-11 15-38-23

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, butnis it not better to horizontally center it? And also, will this work with the Vue rewrite @skjnldsv?

@juliushaertl
Copy link
Member

@jancborchardt No, see discussion in #154

@jancborchardt
Copy link
Member

@juliushaertl the should this fix be merged so it's fixed for pre-Files2Vue versions?

@juliushaertl
Copy link
Member

Need to double check all compatible versions first, but yes we should merge before f2v for the stable releases

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@@ -4,7 +4,7 @@ tr[data-locked='true'] .fileactions .action.action-menu.permanent {
}
.locking-inline-state.icon-password {
padding: 17px 23px;
margin-right: -45px;
margin-right: -49px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this has a similar issue with entries that are not shared:

Screenshot 2023-11-06 at 09 16 17

The following style changes seem to work though:
Screenshot 2023-11-06 at 09 15 52

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check last commit. Both UI content (shared and not shared) should display lock properly, including in grid view.

@skjnldsv skjnldsv removed their request for review November 7, 2023 10:02
@juliushaertl juliushaertl changed the base branch from main to stable27 November 9, 2023 22:08
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested inline

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-fix-lock-state-position branch from c8ce5ec to 5814ba1 Compare February 8, 2024 16:08
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Tested and works

@juliushaertl juliushaertl merged commit 478b6c0 into stable27 Feb 13, 2024
22 checks passed
@juliushaertl juliushaertl deleted the Jerome-Herbinet-fix-lock-state-position branch February 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants