Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to new files API #177

Merged
merged 6 commits into from Nov 10, 2023
Merged

feat: Migrate to new files API #177

merged 6 commits into from Nov 10, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 9, 2023

Fixes #154 with what is currently possible in the files actions API.

I partly adapted the feedback from #157 to use a different icon if the file is locked automatically by collaborative editing.

Design feedback may be addressed separately to get a first prerelease out for 28.

Screenshot 2023-11-09 at 22 21 02 Screenshot 2023-11-09 at 22 23 42 Screenshot 2023-11-09 at 22 23 50

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl marked this pull request as ready for review November 9, 2023 21:20
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@juliushaertl juliushaertl merged commit e498329 into main Nov 10, 2023
26 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/f2v branch November 10, 2023 10:11
@Jerome-Herbinet
Copy link
Member

Hi ! I'm glad to notice that a new icon appeared in Nextcloud 28 … when a file has been open from the web UI and is in this case automatically locked for computer users but not in web UI to preserve collaborative edition.
Capture d’écran du 2024-02-07 16-26-54
In your opinion, could this be backported to Nextcloud 27.1.x ? 😇

@max-nextcloud
Copy link
Collaborator

In your opinion, could this be backported to Nextcloud 27.1.x ? 😇

Seems unlikely as it builds on the new files API which is only available since Nextcloud 28. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[F2V] Lock indicator
5 participants