Fix viewing PDF files with public share links #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nextcloud#286, users have reported that PDF files are not viewable via public share links. The issue was introduced in c992b55 when attempting to encode parts of the URL for files that have special characters. This patch uses the URL Web API to deal with the parts of the URL in a more specific way. Also, the path and files searchParams are set based on `this.filename` and `this.basename` in the same way it is done in the View module when setting `davPath`. This has been tested on private and shared public links on files with and without special characters.
wankdanker
force-pushed
the
issue-286
branch
from
e5667ad
to
0b4e2db
Compare
gsnendzynskigmbh
approved these changes
Feb 12, 2021
|
We also applied this patch (onto v20.0.7). |
|
we have also patched our installation and it works. |
|
Unfortnately this seems the bring back the original issue as then the dav path sections would no longer be escaped properly. I'll have a look into that. |
|
Have the same problem that i cannot open PDF files while PDF viewer app is enabled. Accessing via WEBDAV works fine. Nextcloud 20.0.10 / PDF viewer 2.0.1 seems to double encode the url, e.g every path component like created new ticket here #421 best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #286, users have reported that PDF files
are not viewable via public share links. The issue was introduced in
c992b55 when attempting to encode parts of the URL for files that
have special characters.
This patch uses the URL Web API to deal with the parts of the URL
in a more specific way. Also, the path and files searchParams are
set based on
this.filenameandthis.basenamein the same wayit is done in the View module when setting
davPath.This has been tested on private and shared public links on files
with and without special characters.