Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node engines to next LTS #762

Merged
merged 1 commit into from Jun 22, 2023

Conversation

nextcloud-command
Copy link
Contributor

This PR was automatically generated by the engines dispatcher.

@nextcloud-command nextcloud-command added 3. to review automated dependencies Pull requests that update a dependency file labels Jun 21, 2023
@szaimen
Copy link
Collaborator

szaimen commented Jun 21, 2023

/compile amend /

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
package.json Show resolved Hide resolved
@szaimen szaimen merged commit 355ba3b into master Jun 22, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the automated/update-engines/default branch June 22, 2023 07:06
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 22, 2023
@danxuliu danxuliu mentioned this pull request Jul 12, 2023
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI is broken after this update, although I have not checked exactly why.

The PDF viewer should be fixed to use the new node engines, or the older engines should be used again.

@szaimen
Copy link
Collaborator

szaimen commented Jul 12, 2023

I would suggest using the older node version again then

@danxuliu
Copy link
Member

I would suggest using the older node version again then

Fine by me: #776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review automated dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants