[stable26] Replace deprecated "request" with "axios" #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"request" was used only to get the "pdfjs-XXX-dist.zip" file when building the app, but it was not used in the app itself. It seems that it is not possible (with axios options only) to throttle the "onDownloadProgress" event. Nevertheless, an external throttle function was not used, as the event is not triggered very often and therefore it does not need to be throttled. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
3. to review
dependencies
This was referenced Aug 8, 2023
|
I had to re-run the node job twice because it failed due to removing |
delete-merged-branch
bot
deleted the
backport/740/stable26-replace-deprecated-request-with-axios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #740
I set the milestone to 26.0.6, although technically it does not change anything in the app behaviour (it changes only development dependencies), so it could be in 26.0.5 anyway. But let's respect the RC and not merge yet :-) (hence the draft state)Sigh... I forgot that we have a job that blocks merges during freezes xD