-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ace editor from 1.2.5 to 1.2.8 #47
Conversation
@Acris can you verify if this fixes the problem for you |
@icewind1991 Hi, I got the anwser from postmanlabs/postman-app-support#2530 (comment). As I known, GitLab has the same bug in some version, and I found GitLab use Ace editor too. So I think this bug is from ace editor and they fixed it on 2016. I don't know how to build nextcloud from source so I didn't test it, but I think we should have a try. :-) |
@Acris you can download the package here https://github.com/nextcloud/files_texteditor/archive/ace-1.2.8.zip and then simply replace your apps/files_texteditor/ folder with the one from the zip |
I checked out the branch and could still type. However I don't know how to get the thing to actually show up and do something. Any steps on that? |
@nickvergessen Hello, I replaced
|
When I type |
@nickvergessen You should install a Chinese input method. What OS do you use? If you use macOS or Windows, you can add it from Settings, don't need install 3rd input method. |
Linux mint (ubuntu based) |
@nickvergessen OK, for Linux Mint, you can install fcitx-rime by Maybe you should logout after installed it, then you can add rime input method in Settings. |
I closed the test site. If needed, I'll re-open it. |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Fixes #44
See https://github.com/ajaxorg/ace/blob/master/ChangeLog.txt for all upstream changes