Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ace editor from 1.2.5 to 1.2.8 #47

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Update ace editor from 1.2.5 to 1.2.8 #47

merged 2 commits into from
Aug 2, 2017

Conversation

icewind1991
Copy link
Member

@icewind1991
Copy link
Member Author

@Acris can you verify if this fixes the problem for you

@Acris
Copy link

Acris commented Jul 13, 2017

@icewind1991 Hi, I got the anwser from postmanlabs/postman-app-support#2530 (comment). As I known, GitLab has the same bug in some version, and I found GitLab use Ace editor too. So I think this bug is from ace editor and they fixed it on 2016. I don't know how to build nextcloud from source so I didn't test it, but I think we should have a try. :-)

@nickvergessen
Copy link
Member

@Acris you can download the package here https://github.com/nextcloud/files_texteditor/archive/ace-1.2.8.zip

and then simply replace your apps/files_texteditor/ folder with the one from the zip

@nickvergessen
Copy link
Member

I checked out the branch and could still type. However I don't know how to get the thing to actually show up and do something. Any steps on that?

@Acris
Copy link

Acris commented Jul 14, 2017

@nickvergessen Hello, I replaced apps/files_texteditor/ folder and tried to type some Chinese, I found this bug has been fixed, so this is correct way :)

This is my test site:
http://45.32.50.16:8888
username and password:
test / test

@nickvergessen
Copy link
Member

When I type zhong the thing does not pop up thou, do I need to install something additionally or set my OS to chinese or something?

@Acris
Copy link

Acris commented Jul 14, 2017

@nickvergessen You should install a Chinese input method. What OS do you use? If you use macOS or Windows, you can add it from Settings, don't need install 3rd input method.

@nickvergessen
Copy link
Member

Linux mint (ubuntu based)

@Acris
Copy link

Acris commented Jul 14, 2017

@nickvergessen OK, for Linux Mint, you can install fcitx-rime by apt-get install fcitx-rime.

Maybe you should logout after installed it, then you can add rime input method in Settings.

@Acris
Copy link

Acris commented Jul 17, 2017

I closed the test site. If needed, I'll re-open it.

icewind1991 and others added 2 commits August 2, 2017 22:32
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants