This repository has been archived by the owner on May 28, 2024. It is now read-only.
Add hotkeys support for the video player #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
ChristophWurst
suggested changes
May 13, 2020
| @@ -150,6 +156,7 @@ var videoViewer = { | |||
| videoViewer.showPlayer(); | |||
| }, | |||
| showPlayer: function () { | |||
| import(/* webpackChunkName: "videojs-hotkeys" */ 'videojs-hotkeys') | |||
There was a problem hiding this comment.
you might want to await both imports, right?
Combine them with
Promise.all([
import(...),
import(...),
]).then(...)
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
|
closing as files_videoplayer is not being developed further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The videojs-hotkeys(https://github.com/ctd1500/videojs-hotkeys) can be used as the plugin of video.js. It works perfect. Please merge it.