Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Ignore query arguments in single video share #116

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 5, 2019

Else the url is not constructed properly

Fixes: nextcloud/server#14477

Else the url is not constructed properly

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer merged commit 6370cc1 into master Mar 6, 2019
@rullzer rullzer deleted the fix/query_in_direct_url branch March 6, 2019 09:50
@shubhank008
Copy link

@rullzer my nextcloud 15 install doesn't seem to have the file called main.js and/or by when will you be pushing this as a update in the main app ?

@rullzer
Copy link
Member Author

rullzer commented Mar 6, 2019

this will ship with NC16

@shubhank008
Copy link

shubhank008 commented Mar 6, 2019

@rullzer okay, means cannot apply as a manual fix in NC15 yet ? Also, I think this still does not fix the video url being broken on public share page (query string ?aa=bb still attached), which I think is taking url from here:
videoViewer.location = data.fileList.getDownloadUrl(file, videoViewer.dir);

or nvm, I think thats being taken care by NC16 specific main.js file

@ChristophWurst
Copy link
Member

You might have success applying the patch at https://github.com/nextcloud/files_videoplayer/blob/stable15/js/viewer.js#L150.

@shubhank008
Copy link

shubhank008 commented Mar 6, 2019

Tried applying it but doesn't work, as I mentioned, it's not fixing the public shared link's video playback being broken, as its picking the video URL from the above mentioned code line (also part of viewer.js).

@MorrisJobke MorrisJobke mentioned this pull request Mar 6, 2019
9 tasks
@Ciangi
Copy link

Ciangi commented Jul 10, 2019

Hello,

i have the latest version of Nextcloud - 16.0.3
I have still problem with open mp4 video from shared public link.
The problem occurs in Chrome and Firefox - on Edge is fine.

Scenario:
I shared public link with some directory.
This directory contains 2 sub dirs.
when i enter to one of this sub dirs and try to open mp4 video file i got error that can't open it. ( The same like in nextcloud/server#14477 )

Thank you for any help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any Query string in public shared link breaks Media/Video preview
4 participants