Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract buttons from pages so the animation does not affect t… #1005

Merged
merged 1 commit into from Nov 20, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Nov 15, 2023

No description provided.

Copy link
Collaborator Author

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to block this since layout change breaks the responsive layout

@szaimen szaimen changed the title Revert "revert "Extract buttons from pages so the animation does not affect t…" Extract buttons from pages so the animation does not affect t… Nov 17, 2023
@szaimen
Copy link
Collaborator Author

szaimen commented Nov 17, 2023

@marcoambrosini will you be able to work on this? I think the idea was good but if broke the responsive layout

@marcoambrosini marcoambrosini force-pushed the revert-1003-revert/993/revert-changing-layout branch from 5682a2c to bead0e4 Compare November 20, 2023 07:56
@nextcloud-command nextcloud-command force-pushed the revert-1003-revert/993/revert-changing-layout branch from bead0e4 to f4cf83e Compare November 20, 2023 07:58
@marcoambrosini marcoambrosini force-pushed the revert-1003-revert/993/revert-changing-layout branch from f4cf83e to 00c7aec Compare November 20, 2023 07:59
@marcoambrosini marcoambrosini marked this pull request as ready for review November 20, 2023 07:59
@nextcloud-command nextcloud-command force-pushed the revert-1003-revert/993/revert-changing-layout branch from 00c7aec to 4964c16 Compare November 20, 2023 08:00
@marcoambrosini marcoambrosini force-pushed the revert-1003-revert/993/revert-changing-layout branch from 4964c16 to f807a1c Compare November 20, 2023 08:01
@marcoambrosini
Copy link
Member

/compile amend /

@nextcloud-command nextcloud-command force-pushed the revert-1003-revert/993/revert-changing-layout branch from f807a1c to 30ed7d6 Compare November 20, 2023 08:04
@szaimen szaimen force-pushed the revert-1003-revert/993/revert-changing-layout branch from 30ed7d6 to 345379b Compare November 20, 2023 08:08
@szaimen
Copy link
Collaborator Author

szaimen commented Nov 20, 2023

/compile amend /

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 20, 2023

LGTM now and can be merged as soon as all CI is green :)

Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the revert-1003-revert/993/revert-changing-layout branch from 345379b to be99c1e Compare November 20, 2023 08:09
@szaimen szaimen merged commit a1a1b2f into master Nov 20, 2023
18 checks passed
@szaimen szaimen deleted the revert-1003-revert/993/revert-changing-layout branch November 20, 2023 08:11
@blizzz blizzz mentioned this pull request Nov 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants