Move navigation registration to appinfo.xml #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nickvergessen
approved these changes
May 8, 2018
skjnldsv
approved these changes
May 8, 2018
|
cc @juliushaertl ^ |
|
@MorrisJobke anything missing here? ;) |
|
Ah sorry missed the commit comment, I'll have a look. |
juliushaertl
added a commit
to nextcloud/server
that referenced
this pull request
May 24, 2018
Navigation entries might be handled by javascript, as the about section from nextcloud/firstrunwizard#64 so we don't need a route for that. Signed-off-by: Julius Härtl <jus@bitgrid.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @nickvergessen
Requires nextcloud/server#9421