fixes for Lint and Unit Tests

Signed-off-by: Timotheus Pokorra <timotheus.pokorra@solidcharity.com>

lib/Service/FormsService.php

@@ -150,7 +150,7 @@ public function getOptions(int $questionId): array {
 		}
 	}
 
-	private function getAnswers(int $formId, int $submissionId, string $userId): array|false {
+	private function getAnswers(int $formId, int $submissionId, string $userId): array {
 
 		$answerList = [];
 		$answerEntities = $this->answerMapper->findBySubmission($submissionId);
@@ -230,18 +230,20 @@ public function getForm(int $id): array {
 		$result['questions'] = $this->getQuestions($id);
 
 		// add previous submission if there is one by this user for this form
-		if ($this->currentUser->getUID()) {
+		if ($this->currentUser->getUID() && form->getAllowEdit()) {
 			$submissionEntity = null;
 			try {
 				$submissionEntity = $this->submissionMapper->findByFormAndUser($id, $this->currentUser->getUID());
 				$answers = $this->getAnswers($id, $submissionEntity->getId(), $this->currentUser->getUID());
-				if ($answers !== false) {
+				if (!empty($answers)) {
 					$result['answers'] = $answers;
 					$result['newSubmission'] = false;
 					$result['submissionId'] = $submissionEntity->getId();
 				}
 			} catch (DoesNotExistException $e) {
 				// do nothing
+			} catch (MultipleObjectsReturnedException $e) {
+				// do nothing
 			}
 		}