Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown H1 is not formatted correctly #1668

Closed
mschmidm opened this issue Jul 5, 2023 · 1 comment · Fixed by #1743
Closed

Markdown H1 is not formatted correctly #1668

mschmidm opened this issue Jul 5, 2023 · 1 comment · Fixed by #1743
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Milestone
3.4

Comments

@mschmidm
Copy link
Contributor

mschmidm commented Jul 5, 2023

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
A H1-Markdown element does not get formatted. Other header elements work.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new form
  2. Enter "# h1" into the description input
  3. See output: The "# h1" is formatted like normal text

Expected behavior
The header should not be styled like normal text.

Screenshots
image
image

Nextcloud

  • Nextcloud-Version: 26.0.2
  • Forms-Version: 3.3.1

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser: Chrome
  • Version: 114.0.5735.198

Thank you very much for your work on Forms, it's a really nice app! :)
@mschmidm mschmidm added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Jul 5, 2023
@Chartman123 Chartman123 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 5, 2023
@Chartman123
Copy link
Collaborator

The text is correctly put into <h1> tags in view mode. However, there is some "wrong" styling applied to it.

The computed font size for h1 is 15px, for h2 20px. Whereas the h2 form title has a font size of 28px.

@susnux Do you have an idea where this false styling is coming from?

mschmidm added a commit to mschmidm/forms that referenced this issue Oct 9, 2023
@mschmidm
fix: no styling applied to h1-headings in markdown (closes nextcloud#…
0ef4f61 
…1668)
mschmidm added a commit to mschmidm/forms that referenced this issue Oct 9, 2023
@mschmidm
fix: no styling applied to h1-headings in markdown (closes nextcloud#…
9ae2911 
…1668)

Signed-off-by: Michael Schmidmaier <mschmidm@users.noreply.github.com>
@mschmidm mschmidm mentioned this issue Oct 9, 2023
Merged
mschmidm added a commit to mschmidm/forms that referenced this issue Oct 9, 2023
@mschmidm
fix: no styling applied to h1-headings in markdown (closes nextcloud#…
2ea3fb3 
…1668)

Signed-off-by: Michael Schmidmaier <mschmidm@users.noreply.github.com>
susnux added a commit that referenced this issue Oct 10, 2023
@susnux
Merge pull request #1743 from mschmidm/fix/no-h1-markdown-styling
c88001b 
fix: no styling applied to h1-headings in markdown (closes #1668)
@Chartman123 Chartman123 added this to the 3.4 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Milestone
3.4
Development

Successfully merging a pull request may close this issue.

fix: no styling applied to h1-headings in markdown (closes #1668) mschmidm/forms
2 participants
@Chartman123 @mschmidm