Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minversion 21 - Move to NC internal db column Types #737

Closed
ChristophWurst opened this issue Jan 12, 2021 · 8 comments · Fixed by #1149
Closed

Minversion 21 - Move to NC internal db column Types #737

ChristophWurst opened this issue Jan 12, 2021 · 8 comments · Fixed by #1149
Labels
1. to develop Accepted and waiting to be taken care of integration Compatibility with other apps/systems
Milestone
2.5

Comments

@ChristophWurst
Copy link
Member

Hi there,

I found that your app uses some classes of Nextcloud's third party libraries. Since an upgrade of those for php8 compatibility, your app will have to be adjusted as well. See https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/upgrade-guide.html#doctrine-dbal for details. Your app uses Doctrine\DBAL\Types\Type which lost the old constants: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#deprecated-type-constants.

Cheers
@ChristophWurst ChristophWurst added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 12, 2021
@ChristophWurst
Copy link
Member Author

Please note that we just merged a PR with our own constants for the types, so the app can be fully independent of any 3rdparty libraries: nextcloud/server#25089.

@jotoeri

This comment has been minimized.

Sign in to view
@ChristophWurst

This comment has been minimized.

Sign in to view
@jotoeri

This comment has been minimized.

Sign in to view
@jotoeri jotoeri changed the title Breaking changes in Nextcloud 21 Minversion 21 - Move to NC internal db column Types Feb 23, 2021
@jotoeri jotoeri added 1. to develop Accepted and waiting to be taken care of integration Compatibility with other apps/systems and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Feb 23, 2021
@jotoeri jotoeri added this to the 3.0 milestone Feb 23, 2021
@ChristophWurst

This comment has been minimized.

Sign in to view
@jotoeri

This comment has been minimized.

Sign in to view
@jotoeri jotoeri mentioned this issue Mar 1, 2021
Closed
1 task
@ChristophWurst
Copy link
Member Author

done with #801 I guess

@ChristophWurst
Copy link
Member Author

actually no 🙈

@jotoeri jotoeri mentioned this issue Mar 29, 2022
Merged
@jotoeri jotoeri modified the milestones: 4.0, 3.0, 2.5 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of integration Compatibility with other apps/systems
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

Move to NC-Internal Db-Types nextcloud/forms
2 participants
@ChristophWurst @jotoeri