Manually set Types #801
Manually set Types #801
Conversation
Aaaah, damn! |
|
https://github.com/nextcloud/3rdparty/tree/stable20/doctrine/dbal/lib/Doctrine/DBAL/Types works with 20+ |
| @@ -55,6 +54,11 @@ class Version010200Date20200323141300 extends SimpleMigrationStep { | |||
| 'dropdown' => 'multiple_unique' | |||
| ]; | |||
|
|
|||
| private const TYPE_BOOLEAN = 'boolean'; | |||
| private const TYPE_INTEGER = 'integer'; | |||
| private const TYPE_JSON = 'json'; | |||
There was a problem hiding this comment.
:-X does this even work on all dbs? at least not in our mappers?
There was a problem hiding this comment.
According to doctrine-docs, doctrine will automatically fall back to text in case a DB does not support json. It worked flawless until now...
I just tested this branch with clean installations of all three dabase-types and it works without problems...
There was a problem hiding this comment.
@nickvergessen you're worrying about oracle?
There was a problem hiding this comment.
Can we easily add testing ? Do you have a github workflow file on hand we could steal?
There was a problem hiding this comment.
There was a problem hiding this comment.
@jotoeri can you add this test to this pr? :)
There was a problem hiding this comment.
Then, once green, you can merge! 🚀
skjnldsv
added
2. developing
Fixes NC19 Support Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
skjnldsv
added
4. to release
I'm not really a fan of this, but seems like we need to do this to fix the support for NC19.
Fixes #799