Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Sharing #1087

Merged
merged 8 commits into from May 31, 2022
Merged

New Sharing #1087

merged 8 commits into from May 31, 2022

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Dec 9, 2021 •
edited

So - here it is! 🎉 Ready for Review.
I'm really sorry, it became that much code now in a single PR. Thus i moved fixing the API-versioning to #1126.

Looking forward for the first tests! ☺️

grafik
grafik
AppNavigation is now:
grafik

Fixes #425 😉

@jotoeri jotoeri added design Related to the design enhancement New feature or request feature: 👥 sharing settings labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited

Codecov Report

Merging #1087 (6a6a036) into master (daf8282) will increase coverage by 2.90%.
The diff coverage is 47.64%.

❗ Current head 6a6a036 differs from pull request most recent head b3a4e1b. Consider uploading reports for the commit b3a4e1b to get more accurate results

@@             Coverage Diff              @@
##             master    #1087      +/-   ##
============================================
+ Coverage     29.14%   32.04%   +2.90%     
- Complexity      369      435      +66     
============================================
  Files            36       40       +4     
  Lines          1431     1676     +245     
============================================
+ Hits            417      537     +120     
- Misses         1014     1139     +125

@jotoeri

This comment was marked as outdated.

Sign in to view
@jotoeri jotoeri linked an issue Dec 11, 2021 that may be closed by this pull request
[feature request] Share a form by more than one method. #1090
Closed
@jotoeri jotoeri force-pushed the enh/sharing branch 4 times, most recently from 35c6c69 to 4634cb2 Compare December 17, 2021 21:26
@skjnldsv skjnldsv added the 2. developing Work in progress label Dec 20, 2021
@RenataGegaj

This comment was marked as resolved.

Sign in to view
@jotoeri

This comment was marked as resolved.

Sign in to view
@jotoeri jotoeri force-pushed the enh/sharing branch 10 times, most recently from fdb5553 to 736c089 Compare February 8, 2022 21:10
@jotoeri jotoeri force-pushed the enh/sharing branch 6 times, most recently from 9957233 to 4e9673b Compare February 20, 2022 11:38
@jotoeri jotoeri force-pushed the enh/sharing branch 6 times, most recently from d887be0 to 6c1c20d Compare May 22, 2022 20:24
@jotoeri
Copy link
Member Author

jotoeri commented May 22, 2022 •
edited

Properties are not strong typed, but I thought this may be on purpose if you plan to support older Nextcloud/PHP versions. (24 requires PHP>=7.4 so we can start using strong typed properties there.

Yes, we officially still support NC22 and just recently removed php 7.2. ^^ Thus i'd leave it for now. We'll have a separate PR to change all of our classes, when the time has come. 😉

@jotoeri jotoeri force-pushed the enh/sharing branch 2 times, most recently from a965002 to 20eae6a Compare May 22, 2022 21:40
@jotoeri
Copy link
Member Author

jotoeri commented May 22, 2022

Ok - So thank you, @artonge @CarlSchwan @come-nc for your reviews here! 🚀 Quite a few new things and ideas. I had a look onto all of it, partially just set a comment, but also implemented quite a few things.

So - i think if there's no more issues from your side, this should be good to go, then! ☺️ 🎉

come-nc
come-nc approved these changes May 23, 2022
View reviewed changes
Copy link

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from nitpicking.

I did not test.

lib/Controller/ShareApiController.php Show resolved Hide resolved
lib/Migration/Version030000Date20211206213004.php Outdated Show resolved Hide resolved
@jotoeri jotoeri requested a review from PVince81 May 26, 2022 08:52
@jotoeri
Copy link
Member Author

jotoeri commented May 31, 2022

@artonge Do you wanna check your requested changes? Or should i just dismiss the review as i looked into your comments?

@jotoeri
Move copyShareLink to separate Mixin
46b5306 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Rewrite Sidebar Sharing
89637d9 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Add legacy link, new public link sharing, fix internal view
e2e1f0b 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Load unknown shared forms and provide permission prop
bdaade0 
Also fixes #806

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Fix access on submit
c252c83 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Fix Share-notifications, delete shares with form
d5f16c3 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Open sharing sidebar
3cc0829 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Fix tests
b3a4e1b 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri merged commit e6231fa into master May 31, 2022
@jotoeri jotoeri deleted the enh/sharing branch May 31, 2022 19:58
@come-nc
Copy link

come-nc commented Jun 2, 2022

🚀 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Chartman123 Chartman123 Awaiting requested review from Chartman123

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@RenataGegaj RenataGegaj Awaiting requested review from RenataGegaj

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: 👥 sharing settings high High priority
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

[feature request] Share a form by more than one method. Show sharings as in Server
9 participants
@jotoeri @RenataGegaj @Nemental @nimishavijay @come-nc @PVince81 @artonge @CarlSchwan @skjnldsv