Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Change to uppercase #1205

Merged
merged 2 commits into from
May 17, 2022
Merged

l10n: Change to uppercase #1205

merged 2 commits into from
May 17, 2022

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented May 17, 2022

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet Valdnet self-assigned this May 17, 2022
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ 👍
Would be nice, if you can fix the tests too. It might take a few days until i get to it. 😉 🙈

You could have a look into #1204 to see, where to change it.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet
Copy link
Contributor Author

Valdnet commented May 17, 2022

Would be nice, if you can fix the tests too.

Done 😉.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1205 (14cabb1) into master (b8c89a6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1205   +/-   ##
=========================================
  Coverage     29.14%   29.14%           
  Complexity      369      369           
=========================================
  Files            36       36           
  Lines          1431     1431           
=========================================
  Hits            417      417           
  Misses         1014     1014           

@jotoeri
Copy link
Member

jotoeri commented May 17, 2022

Thanks, @Valdnet ! ❤️

@jotoeri jotoeri merged commit acceea6 into master May 17, 2022
@jotoeri jotoeri deleted the Valdnet-patch-1 branch May 17, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants