Move to button component & first material icons #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotoeri
force-pushed
the
enh/buttons
branch
2 times, most recently
from
8052453
to
2407129
Compare
jotoeri
force-pushed
the
enh/buttons
branch
8 times, most recently
from
02c06bd
to
dfbb212
Compare
jotoeri
added
3. to review
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Chartman123
reviewed
Aug 19, 2022
Chartman123
approved these changes
Aug 20, 2022
jotoeri
added
4. to release
skjnldsv
approved these changes
Aug 21, 2022
|
Hm, would still be good to use a button with text there? Secondary with icon for both "Results" and "Back to questions" would be good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to NcButton instead of manually styled ones.
New Toolbar is icon-only with tooltip 馃檪: