feat: Add slot for additional actions to the question component #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
added
enhancement
|
@susnux on the other hand this means duplicated code if an extra setting is valid for multiple question types... I'm not sure what's better here. |
True. I moved the shuffle option to show how this could be used, but if you think we should keep it in question (shared for two question types) I am fine with it and revert that. |
|
As it is now, the shuffleOptions feels a bit more logically bound to the question-type it belongs to. So for me, both is fine here...
|
|
Ok, then let's move it to the question types :) |
Chartman123
approved these changes
Jan 31, 2023
jotoeri
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a slot for additional, question specific, settings and moved the shuffle option to only the required questions.
Did this to allow further custom question settings without adding more, mostly useless, properties to the question component. E.g. such a feature could be the validation of a short question.
I am not 100% sure about the position of the slot, I think
delete the questionshould always be the last option, but not sure if all other common options should be above the slot or also below the slot.