Notify users on new submissions for shared forms #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
============================================
+ Coverage 42.12% 42.57% +0.44%
- Complexity 570 581 +11
============================================
Files 55 56 +1
Lines 2381 2403 +22
============================================
+ Hits 1003 1023 +20
- Misses 1378 1380 +2 |
jotoeri
reviewed
Mar 7, 2023
susnux
force-pushed
the
feat/notify-shared-forms
branch
from
1004858
to
a37039b
Compare
susnux
force-pushed
the
feat/notify-shared-forms
branch
2 times, most recently
from
8224976
to
6185383
Compare
susnux
force-pushed
the
feat/notify-shared-forms
branch
2 times, most recently
from
12ceaa2
to
ed05842
Compare
Chartman123
approved these changes
Sep 29, 2023
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
feat/notify-shared-forms
branch
2 times, most recently
from
4dc29e4
to
def3432
Compare
Also move activity creation from controller into service. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
feat/notify-shared-forms
branch
from
def3432
to
2afddc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to receive notifications for new submissions of shared forms, meaning forms of which the user has results permissions.
Currently only the owner is notified but not other users.
Use cases: Not only you but the whole team should be informed of new submissions.
I have added a new notification setting / type for this, so users can disable e.g. mail notifications for shared forms but still get them for their own forms.