Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sanitize file name when writing a CSV file #1660

Merged
merged 1 commit into from Jun 29, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Jun 28, 2023

Sanitize the file name created for a CSV file by replacing all invalid characters with dashes.

馃И Test case included!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: 馃搳 responses & statistics labels Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1660 (6cf541d) into main (1be02c1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1660      +/-   ##
============================================
+ Coverage     40.03%   40.05%   +0.02%     
  Complexity      562      562              
============================================
  Files            55       55              
  Lines          2378     2379       +1     
============================================
+ Hits            952      953       +1     
  Misses         1426     1426              

Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 馃憤馃徎

@Chartman123 Chartman123 merged commit 33a7ff3 into main Jun 29, 2023
24 checks passed
@Chartman123 Chartman123 deleted the fix/escape-invalid-filename-chars branch June 29, 2023 06:43
@Chartman123 Chartman123 added this to the 3.4 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: 馃搳 responses & statistics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create file when saving to CSV when title has / in it
2 participants