Optimization of FormMapper::findById calls

[AIlkiv]

Motivation:

There is a method called ApiController::getSharedForms, which is invoked on the main page of the module.

This method retrieves all web forms without exception.

And then this method invokes various other methods to obtain the Form using its formId. In essence, it performs N (representing the total number of forms in the system) additional requests to the database. Even if these requests are somehow cached, they still amount to N unnecessary cache requests.

For other methods, the number of findById calls is reduced.

[codecov]

Codecov Report

Merging #1707 (29d2b6f) into main (0c2eb7e) will decrease coverage by 0.22%.
Report is 2 commits behind head on main.
The diff coverage is 70.21%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1707      +/-   ##
============================================
- Coverage     42.33%   42.12%   -0.22%     
  Complexity      570      570              
============================================
  Files            55       55              
  Lines          2388     2381       -7     
============================================
- Hits           1011     1003       -8     
- Misses         1377     1378       +1     

[AIlkiv]

@Chartman123 could you kindly perform a code review, please?

[Chartman123]

Hi @AIlkiv

sorry, I don't have much time at the moment. Will try to review your PR next week.

[susnux]

Very nice work, code looks good and make sense

[Chartman123]

Fine for me as well :) Could you please do another rebase on latest main and then I think we can merge this one.