fix: Warning about missing label for other answer #1731
Conversation
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
added
enhancement
| @@ -72,7 +72,7 @@ | |||
| @keydown.enter.exact.prevent="onKeydownEnter"> | |||
| {{ t('forms', 'Other:') }} | |||
| </NcCheckboxRadioSwitch> | |||
| <NcInputField :placeholder="placeholderOtherAnswer" | |||
| <NcInputField :label="placeholderOtherAnswer" | |||
There was a problem hiding this comment.
No, this makes no sense for accessibility, as the label of the input would be "Enter your answer".
It would make more sense to have a separate label like "Custom answer" or "Other answer" and keep "Enter your answer" as the placeholder.
There was a problem hiding this comment.
Or we could change the placeholder text for submitPlaceholder to "Enter your own answer"? This way we wouldn't need another string...
We also have the "other" label for the checkbox in front, so it might already be clear that the following input field belongs to the "other" option. But I'm far from being an a11y expert...
There was a problem hiding this comment.
Lets do this for now. As soon as we use nextcloud/vue 8 we could just use the inner labels and rework this :)
NcInputField for other answer throws a warning about missing label prop. As label also works as placeholder, this simply changes the prop for the placeholder text from placeholder to label.