Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make form editable with keyboard #1750

Merged
merged 1 commit into from Nov 12, 2023
Merged

fix: Make form editable with keyboard #1750

merged 1 commit into from Nov 12, 2023

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Oct 19, 2023

This fixes #416 by always showing the edit mode for all fields in Edit/Create view

grafik

To-Do:

  • Fix tabbing from multilple choice questions to next question. Probably due to switching between normal Input and AnswerInput.vue (also tracked in Focus order issues #1256)
  • Focus after adding question not in title
  • emit onInput event after creating a new option only works after first input

@Chartman123 Chartman123 added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress feature: 📑 form creation labels Oct 19, 2023
@Chartman123 Chartman123 added this to the 3.4 milestone Oct 19, 2023
@Chartman123 Chartman123 changed the title Make form header editalbe with keyboard Make form header editable with keyboard Oct 20, 2023
@Chartman123 Chartman123 changed the title Make form header editable with keyboard fix: Make form editable with keyboard Oct 27, 2023
@Chartman123 Chartman123 force-pushed the fix/a11y-edit-form branch 6 times, most recently from e284d58 to c979516 Compare October 27, 2023 21:11
@Chartman123 Chartman123 self-assigned this Oct 29, 2023
@Chartman123 Chartman123 force-pushed the fix/a11y-edit-form branch 3 times, most recently from 6f9453e to 0e72509 Compare November 1, 2023 00:07
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 1, 2023
@Chartman123 Chartman123 marked this pull request as ready for review November 1, 2023 00:15
@Chartman123
Copy link
Collaborator Author

@susnux @jotoeri While reviewing, please especially have a closer look at my second and third commit. They make the code work the way I wanted, but I'm not sure if there weren't better solutions :)

@Chartman123 Chartman123 linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, one comment.
But it seems that adding new options on pressing enter is broken now

src/components/Questions/AnswerInput.vue Outdated Show resolved Hide resolved
@Chartman123
Copy link
Collaborator Author

But it seems that adding new options on pressing enter is broken now

@susnux Yes, thats true. I will have another look at this...

Do you have an idea how I can fix the problem that new options will only be added to the database when you have at least more than one input events on a new option field? I couldn't find any working solution myself by now...

@Chartman123 Chartman123 force-pushed the fix/a11y-edit-form branch 2 times, most recently from 717747b to 869cd3c Compare November 9, 2023 23:02
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works but one comment

src/components/Questions/QuestionMultiple.vue Outdated Show resolved Hide resolved
src/components/Questions/QuestionMultiple.vue Outdated Show resolved Hide resolved
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 merged commit e1b980b into main Nov 12, 2023
22 checks passed
@Chartman123 Chartman123 deleted the fix/a11y-edit-form branch November 12, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment