Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverted sorting in frontend for shared forms #1759

Merged
merged 1 commit into from Oct 26, 2023
Merged

Fix inverted sorting in frontend for shared forms #1759

merged 1 commit into from Oct 26, 2023

Conversation

Chartman123
Copy link
Collaborator

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added the bug Something isn't working label Oct 25, 2023
@Chartman123 Chartman123 added the javascript Javascript related ticket label Oct 25, 2023
@Chartman123 Chartman123 added this to the 3.4 milestone Oct 25, 2023
@Chartman123 Chartman123 added the design Related to the design label Oct 25, 2023
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Oct 25, 2023
@Chartman123 Chartman123 self-assigned this Oct 25, 2023
@Chartman123
Fix inverted sorting in frontend for shared forms
7eba562 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
susnux
susnux approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(b, a) looks weird but will do it ^^

@Chartman123 Chartman123 merged commit 6d74165 into main Oct 26, 2023
22 checks passed
@Chartman123 Chartman123 deleted the fix/sort-shared-forms branch October 26, 2023 06:15
jancborchardt
jancborchardt reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a bunch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@susnux susnux susnux approved these changes

Assignees

@Chartman123 Chartman123

Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design javascript Javascript related ticket
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chartman123 @jancborchardt @susnux