fix(Question): close question menu after copy question #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
added
javascript
Chartman123
changed the title
susnux
approved these changes
Dec 26, 2023
susnux
reviewed
Dec 26, 2023
| @@ -99,7 +99,8 @@ | |||
| </template> | |||
| {{ t('forms', 'Technical name') }} | |||
| </NcActionInput> | |||
| <NcActionButton @click="onClone"> | |||
| <NcActionButton :close-after-click="true" | |||
There was a problem hiding this comment.
For boolean properties this is not needed and depends on your preference / styleguide as this is the same like:
Suggested change
| <NcActionButton :close-after-click="true" | |
| <NcActionButton close-after-click |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some focus jumping after copying a question by closing the action menu after the click.
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de