Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use separate chunk for vue and vue-router to prevent multiple imports #1853

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Dec 26, 2023

Fixes #1842

For some reason vue and vue-router are imported multiple times by different chunks, this causes errors as vue2 is not allowed to be used more than one time in one application.
So it is fixed by create a manual chunk just for vue, vue-router and its dependencies.

…e imports

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Dec 26, 2023
@Chartman123
Copy link
Collaborator

Chartman123 commented Dec 26, 2023

@susnux If you close the picker without selecting a file/folder, there's another error message in the console:

Uncaught (in promise) Error: FilePicker: No nodes selected

Do you think you can add fix for that to this PR as well or should we create a separate PR for that as this also appears on instances where the original issue isn't showing up?

Forget everything, I've just seen that you fixed that in the other PR as well regarding the buttons ;)

Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked it on my productive instance where I had the issue. The file picker opens like expected.

@Chartman123 Chartman123 merged commit b58a99b into main Dec 26, 2023
34 checks passed
@Chartman123 Chartman123 deleted the fix/create-sparate-chunk-for-vue branch December 26, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Resultat as CSV to Files not functional
2 participants