enh: Use NcDialog to confirm leaving #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chartman123
added
enhancement
Chartman123
force-pushed
the
enh/use-ncdialog-leave
branch
from
0a2e684
to
19dc4e4
Compare
Chartman123
added
3. to review
Chartman123
force-pushed
the
enh/use-ncdialog-leave
branch
2 times, most recently
from
32aca08
to
af34179
Compare
|
I get the dialog even if no answers were entered? vokoscreenNG-2024-01-25_17-57-56.mp4 |
Chartman123
force-pushed
the
enh/use-ncdialog-leave
branch
from
af34179
to
dd172b4
Compare
Should be fixed now :) |
susnux
reviewed
Jan 25, 2024
Chartman123
force-pushed
the
enh/use-ncdialog-leave
branch
from
dd172b4
to
9c45d14
Compare
susnux
reviewed
Jan 25, 2024
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
enh/use-ncdialog-leave
branch
from
9c45d14
to
8050411
Compare
susnux
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses NcDialog for warning the user before leaving an unsubmitted form instead of the default confirm dialog of the browsers. Due to limitations of the browsers this only works for route changes within the Forms app. When switching to other apps, another website or closing the tab/window, the default dialog will still be used.