Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(tests): Add initial cypress tests for frontend testing #1891

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Jan 22, 2024

This adds a skeleton for creating frontend tests using Cypress.
We often had frontend related regressions so lets start testing the UI to notice and breaking stuff.

I tried to keep the PR small so only a minimal example for a test is added, I will add further tests after this is merged :)

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Jan 22, 2024
@susnux susnux added this to the 4.1 milestone Jan 22, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/cypress-tests branch 2 times, most recently from 45704c9 to dbe4fc2 Compare January 23, 2024 22:49
Otherwise we would need to pay Cypress for parallel testing.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6a4264) 44.61% compared to head (aeb59f4) 44.79%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1891      +/-   ##
============================================
+ Coverage     44.61%   44.79%   +0.17%     
- Complexity      662      686      +24     
============================================
  Files            58       59       +1     
  Lines          2600     2697      +97     
============================================
+ Hits           1160     1208      +48     
- Misses         1440     1489      +49     

@susnux
Copy link
Collaborator Author

susnux commented Jan 23, 2024

@Chartman123 ready now :)

@Chartman123
Copy link
Collaborator

@susnux can we have it one commit? then we can merge it :)

@susnux
Copy link
Collaborator Author

susnux commented Jan 24, 2024

can we have it one commit? then we can merge it :)

Yes, was just for testing

@susnux susnux merged commit 9542f06 into main Jan 24, 2024
50 checks passed
@susnux susnux deleted the feat/cypress-tests branch January 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants