Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharing form #1907

Merged
merged 1 commit into from Jan 26, 2024
Merged

Fix sharing form #1907

merged 1 commit into from Jan 26, 2024

Conversation

avinash-0007
Copy link

@avinash-0007 avinash-0007 commented Jan 26, 2024

  • Sharing form to all logged in user by enabling Permit access to all logged in accounts only works if that other user already a form created or Show to all accounts on sidebar is also enabled

  • If a user try to open a form using shared link and not created any form will not able to see form .

  • I find that this hasForms always false if user not created any form and also the shared form link not enabled this Show to all accounts on sidebar option

  • To fix this <NcAppContent v-if="loading || !hasForms || !routeHash || !routeAllowed"> => <NcAppContent v-if="loading || !routeHash || !routeAllowed"> - removing !hasForms will solves this issue.

  • Also this MR fixes this issue "Public access to all logged in accounts" not working – Form not accessible for all users #1779

Signed-off-by: Avinash Gusain <avinashg@e.email>
@Chartman123
Copy link
Collaborator

/backport to stable3

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 26, 2024
@Chartman123 Chartman123 added this to the 4.1 milestone Jan 26, 2024
@susnux susnux merged commit a80cb66 into nextcloud:main Jan 26, 2024
37 checks passed
Copy link

backportbot bot commented Jan 26, 2024

The backport to stable3 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable3
git pull origin stable3

# Create the new backport branch
git checkout -b backport/1907/stable3

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdfdc8fe2d209eb5f817d7675743aa44d8e2285c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1907/stable3

Error: Failed to create pull request: Failed to request reviews: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the nextcloud/forms repository.


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working feature: 👥 sharing settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Public access to all logged in accounts" not working – Form not accessible for all users
3 participants